Skip to content

Widen the signature of code_info #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Widen the signature of code_info #16

merged 2 commits into from
Feb 27, 2022

Conversation

KDr2
Copy link
Contributor

@KDr2 KDr2 commented Feb 24, 2022

Fix #12.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #16 (6fb1911) into master (510d0e4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files           1        1           
  Lines         275      275           
=======================================
  Hits          273      273           
  Misses          2        2           
Impacted Files Coverage Δ
src/CodeInfoTools.jl 99.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510d0e4...6fb1911. Read the comment docs.

@devmotion
Copy link
Contributor

Maybe add the failing example as test?

@femtomc
Copy link
Member

femtomc commented Feb 24, 2022

@KDr2 yep, if you can add the struct example as a test, that would be great.

@KDr2
Copy link
Contributor Author

KDr2 commented Feb 24, 2022

@femtomc done.

@femtomc femtomc merged commit 409874a into JuliaCompilerPlugins:master Feb 27, 2022
@KDr2 KDr2 deleted the issue-12 branch February 27, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code_info doesn't work on structure constructors
3 participants