Skip to content

deprecated kw.data and nt.names #200

@JeffFessler

Description

@JeffFessler

I'm getting a warning and an error on a nightly build:

 Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #AxisArray#7 at core.jl:243 [inlined]

...

  type DataType has no field names
  Stacktrace:
    [1] getproperty(x::Type, f::Symbol)
      @ Base ./Base.jl:37
    [2] #s11#8
      @ ~/.julia/packages/AxisArrays/IFpjG/src/core.jl:244 [inlined]

The error is from this apparently deprecated use of nt.names:

@generated nt_to_axes(nt::NamedTuple) =

The warning is due to this apparently deprecated use of kw.data:

AxisArray(A; kw...) = AxisArray(A, nt_to_axes(kw.data)...)

Probably related to this:
JuliaLang/julia#39448

I'll made a PR, but I am a bit concerned about the long delays in the existing PRs, e.g., from @johnnychen94. He has even volunteered to help with maintenance here in one of his PRs but no reply in a month. I realize the package developers are probably super busy because they have created so many terrific packages.
So how about enabling some others to help and spread the work around? I'm also willing to help.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions