Skip to content

Update target_transformations.md #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

Update target_transformations.md #1137

merged 1 commit into from
Jul 19, 2024

Conversation

era127
Copy link
Contributor

@era127 era127 commented Jul 14, 2024

This sentence doesn't seem to relate to the examples (ridge and ridge2) on rest of the page which use a different dataset.

Perhaps the two examples for ridge and ridge2 were supposed to use the load_boston dataset as well?

@era127
Update target_transformations.md
d429c31 
This sentence doesn't seem to relate to the examples (ridge and ridge2) on rest of the page which use a different dataset. 

Perhaps the two examples for ridge and ridge2 were supposed to use the load_boston dataset as well?
ablaom
ablaom approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @era127, thank you.

I think we can view as the original purpose of these lines as lost in the Mists of Time and safely dump them, as you suggest.

@ablaom ablaom closed this Jul 19, 2024
@ablaom ablaom reopened this Jul 19, 2024
@ablaom ablaom merged commit 3045942 into JuliaAI:dev Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom ablaom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@era127 @ablaom