Implement concat of extract AST simplifications#940
Merged
JonathanSalwan merged 1 commit intoJonathanSalwan:dev-v0.9from Sep 15, 2020
Merged
Conversation
SweetVishnya
force-pushed
the
concat-extract-simplification
branch
from
353fa49 to
f079d9a
Compare
src/libtriton/ast/astContext.cpp
Outdated
| } | ||
|
|
||
| if (this->modes->isModeEnabled(triton::modes::AST_OPTIMIZATIONS) && | ||
| node->getBitvectorSize() <= 512) { |
Owner
There was a problem hiding this comment.
&& node->getBitvectorSize() <= 512 is always true?
| } | ||
|
|
||
| if (this->modes->isModeEnabled(triton::modes::AST_OPTIMIZATIONS) && | ||
| node->getBitvectorSize() <= 512) { |
Owner
There was a problem hiding this comment.
&& node->getBitvectorSize() <= 512 is always true?
Contributor
Author
There was a problem hiding this comment.
No longer need this check. I will remove it.
| return this->astRepresentation.print(stream, node); | ||
| } | ||
|
|
||
| SharedAbstractNode AstContext::simplify_concat(std::vector<SharedAbstractNode> exprs) { |
Owner
There was a problem hiding this comment.
Can you add some comments at each steps to help me (and others) to understand the algorithm. What you are looking for, what/how you do it. etc. If you can also avoid to name variables like : r, e, n. If they can have a better name to quickly identify their role, it will be nice :)
Owner
|
erf, goddamnit conflict. |
Contributor
Author
|
Should I rebase? |
Owner
|
if you can, it will be cool yep |
SweetVishnya
force-pushed
the
concat-extract-simplification
branch
from
4933d83 to
29b9ac0
Compare
Contributor
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #930