Skip to content

Conversation

wolliq
Copy link
Contributor

@wolliq wolliq commented Nov 20, 2021

Description

Bugfix on date relaxed matcher that catches month subwords, e.g. gauge => aug and parses the wrong month.

Motivation and Context

Issue #6459 .

How Has This Been Tested?

Full regression is green with an added test on the specific use case.

Screenshots (if appropriate):

[info] Tests: succeeded 621, failed 0, canceled 0, ignored 5, pending 0
[info] All tests passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wolliq wolliq requested a review from maziyarpanahi November 20, 2021 11:28
@maziyarpanahi maziyarpanahi linked an issue Nov 20, 2021 that may be closed by this pull request
@maziyarpanahi maziyarpanahi self-assigned this Nov 20, 2021
@maziyarpanahi maziyarpanahi merged commit 758d124 into release/333-release-candidate Nov 20, 2021
@KshitizGIT KshitizGIT deleted the bugfix/date-relaxed-matcher-subword-month branch March 2, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateParser failing to detect dates
2 participants