Skip to content

Modifies Models Resolution #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2021
Merged

Modifies Models Resolution #6458

merged 2 commits into from
Nov 17, 2021

Conversation

danilojsl
Copy link
Contributor

Description

Modifies sorting when resolving resources based on Spark version. In case Spark versions are the same, it sortes based on Spark-NLP version.

Motivation and Context

See issue 1003 reported on commercial spark-nlp

How Has This Been Tested?

Adding unit tests and testing current ones.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@maziyarpanahi maziyarpanahi self-assigned this Nov 13, 2021
@maziyarpanahi maziyarpanahi added enhancement on-hold cannot be merged right away DON'T MERGE Do not merge this PR labels Nov 13, 2021
@maziyarpanahi maziyarpanahi changed the base branch from master to release/333-release-candidate November 17, 2021 10:13
@maziyarpanahi maziyarpanahi merged commit 45253e9 into release/333-release-candidate Nov 17, 2021
@maziyarpanahi maziyarpanahi mentioned this pull request Nov 17, 2021
Merged
@KshitizGIT KshitizGIT deleted the hotfix/model-resolution branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@maziyarpanahi maziyarpanahi

Labels
DON'T MERGE Do not merge this PR enhancement on-hold cannot be merged right away
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilojsl @maziyarpanahi