-
Notifications
You must be signed in to change notification settings - Fork 732
Multicolumns approach #6446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicolumns approach #6446
Conversation
f6c2a49
to
2aa0d3a
Compare
@maziyarpanahi I add it the documentation and remove one commit that was from other branch |
@xusliebana the references to |
3770b2e
to
d190197
Compare
d190197
to
3f52364
Compare
@maziyarpanahi Done |
Thanks @xusliebana |
/** | ||
* Trait used to create annotators with input columns of variable length. | ||
* */ | ||
trait HasMultipleInputAnnotationCols extends HasInputAnnotationCols { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maziyarpanahi @xusliebana , don't you guys think that the name for this trait could be HasVariableCountInputAnnotationCols
HasInputAnnotationCols already supports multiple input columns, the main change I see here is that the number of columns will no longer be defined in a 'declarative' fashion inside the library, but in a more dynamic way by the user, during annotator setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertoandreottiATgmail Yes, that totally makes sense! I'll leave it to you and @xusliebana to rename this and the unit tests. (@xusliebana you can directly fix the changes inside release/333-release-candidate branch)
@albertoandreottiATgmail Could you please also review removing final
from final def setInputCols()
? I am not sure why we used final
so I want to be sure removing it won't be risky in some scenarios.
Add an interface to use multiple input annotations columns
Description
Motivation and Context
We need to have an interface to allow to use of multiple input annotations in the healthcare repo.
How Has This Been Tested?
I created a unit test that show that is working that approach
Types of changes
Checklist: