Skip to content

[SPARKNLP-1194] Upgrade jsl-llamacpp to newest version #14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DevinTDHa
Copy link
Member

@DevinTDHa DevinTDHa commented Jul 23, 2025

Description

This PR upgrades the llama.cpp version of Spark NLP to b5932. This enables inference of the newest LLMs such as Gemma3, Phi4 etc.

Temporarily, AutoGGUFVisionModel is disabled, as we are working to integrate it again with the new llama.cpp architecture.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Embeddings Passing
- Adjust metadata extraction
- Fix changed parameters
- Add default system prompt
- Default params for AutoGGUFEmbeddings
@DevinTDHa DevinTDHa changed the title Upgrade jsl-llamacpp to newest version [SPARKNLP-1194] Upgrade jsl-llamacpp to newest version Jul 23, 2025
@DevinTDHa DevinTDHa merged commit 3567250 into JohnSnowLabs:release/610-release-candidate Jul 23, 2025
1 of 4 checks passed
@DevinTDHa DevinTDHa mentioned this pull request Jul 23, 2025
10 tasks
DevinTDHa added a commit that referenced this pull request Jul 23, 2025
* Upgrade jsl-llama.cpp

- Embeddings Passing
- Adjust metadata extraction
- Fix changed parameters
- Add default system prompt
- Default params for AutoGGUFEmbeddings

* jsl-llama.cpp upgrade python side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant