💬 How to apply rules like in v1 for v2?

[hbinduni]

i create rules for v1 like below:

converter := htmltomarkdown.NewConverter("", true, nil)

// Add a custom rule for the <img> tag
converter.AddRules(
htmltomarkdown.Rule{
	Filter: []string{"img"},
	Replacement: func(content string, node *goquery.Selection, options *htmltomarkdown.Options) *string {
		// Get attributes from the <img> tag
		src, _ := node.Attr("src")
		alt, _ := node.Attr("alt")
		title, _ := node.Attr("title")

		// Return a custom Markdown format
		result := fmt.Sprintf("![Custom Format | Alt: %s | Title: %s](%s)", alt, title, src)
		return &result
	},
},
)

how to apply rules for v2?
is that correct to apply rules like v1 using custom render in v2?
something like this:

conv := converter.NewConverter(
		converter.WithPlugins(
			base.NewBasePlugin(),
			commonmark.NewCommonmarkPlugin(),
		),
	)
	
conv.Register.RendererFor("img", converter.TagTypeInline, func(ctx converter.Context, w converter.Writer, node *html.Node) converter.RenderStatus {
		src := getAttribute(node, "src")
		alt := getAttribute(node, "alt")
		title := getAttribute(node, "title")

		// Custom Markdown for <img> tags
		w.WriteString(fmt.Sprintf("![Custom Format | Alt: %s | Title: %s](%s)", alt, title, src))
		return converter.RenderSuccess
	}, converter.PriorityEarly)

thank you

[JohannesKaufmann]

• There is an example for Register in examples/register/main.go

• You can use the function dom.GetAttributeOr(node, "alt", "") from the "github.com/JohannesKaufmann/dom" package.

• The Rule in V1 was quite limited. With V2 there is a lot more customisation possible. For most case the RendererFor is what you need.

• If you want to package logic, you can optionally package it into a plugin. But registering it like you do right now is perfectly okay.

• @hbinduni The logic above seems to be good 👍

[hbinduni]

Thank you for your help

[JohannesKaufmann]

No problem, happy to help!

Let me know if you have any other questions...