Fix RedisArray definition #1772
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @isfedorov @LolGleb
RedisArray is currently using
@mixin Redis
but even if Redis and RedisArray has similar function they don't have the same signature.As an example
keys(string $pattern): bool|array;
in RedisArray vs the same method in Redis which returnsRedis|array|bool
.So it seems better to remove the
@mixin
and copy paste the stub from https://github.com/phpredis/phpredis/blob/develop/redis_array.stub.php