Improve DomNode methods return type #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Jul 20, 2025
| * The old node. | ||
| * </p> | ||
| * @return DOMNode|false The old node or false if an error occur. | ||
| * @return TNode|false The old node or false if an error occur. |
There was a problem hiding this comment.
According to the phpdoc and https://www.php.net/manual/en/domnode.replacechild.php
the old node is returned which is the second param if I understand.
| * The removed child. | ||
| * </p> | ||
| * @return DOMNode If the child could be removed the functions returns the old child. | ||
| * @return TNode|false If the child could be removed the functions returns the old child. |
There was a problem hiding this comment.
This returns the child removed (which is the one in param)
AND false was missing
| * The appended child. | ||
| * </p> | ||
| * @return DOMNode The node added. | ||
| * @return TNode|false The node added. |
There was a problem hiding this comment.
This returns the node added (which is coming form the param)
AND false was missing
VincentLanglet
commented
Jul 20, 2025
| * The new node. | ||
| * </p> | ||
| * @param null|DOMNode $child [optional] <p> | ||
| * The reference node. If not supplied, newnode is | ||
| * appended to the children. | ||
| * </p> | ||
| * @return DOMNode The inserted node. | ||
| * @return TNode|false The inserted node. |
There was a problem hiding this comment.
According to the phpdoc and https://www.php.net/manual/en/domnode.insertbefore.php
it returns the node inserted, which is the one coming from the param.
AND false was missing
VincentLanglet
commented
Jul 20, 2025
| @@ -226,7 +230,7 @@ public function hasChildNodes(): bool {} | |||
| * Indicates whether to copy all descendant nodes. This parameter is | |||
| * defaulted to false. | |||
| * </p> | |||
| * @return static The cloned node. | |||
| * @return static|false The cloned node. | |||
|
I saw you review some of my PR @LolGleb ; do you mind taking a look at this one too ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @isfedorov