[ui] fix scaling when copying checkbox icons #3363
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
force-pushed
the
julia/checkbox-icon-scale
branch
from
3fefd1e to
4e97356
Compare
When the JBCachingScalableIcon is copied for scaling, the initial scale value must be propagated from the source icon via JBScalableIcon#updateContextFrom. CheckboxIcon.WithColor did not have a constructor that accepts the source icon, so copied instances could end up with an incorrect size. This commit adds a constructor to CheckboxIcon.WithColor that takes source icon and allows to properly preserve the scale. IJPL-225566
juliabeliaeva
force-pushed
the
julia/checkbox-icon-scale
branch
from
4e97356 to
1d7fc7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the JBCachingScalableIcon is copied for scaling, the initial scale value must be propagated from the source icon via JBScalableIcon#updateContextFrom. CheckboxIcon.WithColor did not have a constructor that accepts the source icon, so copied instances could end up with an incorrect size. This commit adds a constructor to CheckboxIcon.WithColor that takes source icon and allows to properly preserve the scale.
IJPL-225566