fix: Look in callee to determine no return state #3350
+72
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you consider such a hacky way to look into callees?
Fixes https://youtrack.jetbrains.com/issue/PY-72253/False-positive-Local-variable-x-might-be-referenced-before-assignment-after-try-except-block-when-a-function-call-in-except
Note
When a call target lacks a never-return annotation, analyze the callee’s control-flow to treat calls as no-return if the function’s exit is unreachable, with caching and limits; adds a test for a raising callee.
CallInstruction.ktto detect no-return calls by inspecting callee CFG when no explicit return type is provided.functionIsEffectivelyNoReturnand DFS-basedexitIsReachablewith safety limits to avoid large/complex graphs.ControlFlowIsAbruptAfterRaisingCallee.py/.txttest data.testControlFlowIsAbruptAfterRaisingCalleeinPyControlFlowBuilderTest.java.Written by Cursor Bugbot for commit a4ceedd. This will update automatically on new commits. Configure here.