fix: Indent async implementation method correctly #3349
+56
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/PY-53074/Implement-abstract-methods-produces-syntax-error-for-async-methods
Note
Adjusts method insertion to handle classes without bodies (ensuring correct indentation, including async), and adds tests for nested indentation and abstract method order.
writeMemberinpython/src/com/jetbrains/python/codeInsight/override/PyOverrideImplementUtil.javato build the function first and insert it viaPyPsiRefactoringUtil.addElementToStatementListwhen noanchoris present, ensuring correct indentation for empty/nested class bodies (incl. async methods).ImplementAbstractNestedIndentation.pyand_after.pyto verify correct indentation when implementing async methods in nested classes.ImplementAbstractOrder.pyand_after.pyto includefoo2and validate implementation order.testImplementAbstractNestedIndentationinPyQuickFixTest.kt; keeptestImplementAbstractOrderupdated.Written by Cursor Bugbot for commit 8dcae90. This will update automatically on new commits. Configure here.