Skip to content

Conversation

@akerimsenol
Copy link
Contributor

@akerimsenol akerimsenol commented Dec 15, 2025

Note

Unifies holder and source set module naming, especially under phased sync, by routing through new helper overloads that use build path and root project name.

  • Gradle module naming:
    • Phased sync: getInternalModuleName now builds names via getHolderModuleName(...) or resolveSourceSetModuleName(...) using build root path and root project name.
    • New overloads: add private getHolderModuleName(ProjectResolverContext, Path, String, ExternalProject) and resolveSourceSetModuleName(ProjectResolverContext, Path, String, ExternalProject, String); public variants delegate to them.
    • Conflict handling: when a computed source set module name already exists in EntityStorage, append ~1.

Written by Cursor Bugbot for commit e2fa3a6. This will update automatically on new commits. Configure here.

@HackerMadCat HackerMadCat self-assigned this Dec 15, 2025
@nskvortsov
Copy link
Contributor

Please add a test covering this fix. E.g., you could run sync two times with different values for the gradle.phased.sync.bridge.disabled and assert that modules have consistent names.

@nskvortsov nskvortsov added the Waiting for Reply The author needs to provide additional details requested by IntelliJ IDEA developers label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for Reply The author needs to provide additional details requested by IntelliJ IDEA developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants