Skip to content

Conversation

@akerimsenol
Copy link
Contributor

@akerimsenol akerimsenol commented Dec 15, 2025

Note

Generalizes duplicate URL pruning to ContentRootEntity, SourceRootEntity, and ExcludeUrlEntity with shared-source-aware logic, replacing the previous content-root-only approach.

  • Gradle JPS Sync:
    • Replace removeDuplicatedContentRoots with a generic removeDuplicatedUrlEntities<T> that de-duplicates by (url, module).
      • Applies to ContentRootEntity, SourceRootEntity, and ExcludeUrlEntity.
      • Uses shared-source-aware keys: allows duplicates across modules when shared source support is enabled, but removes duplicates within the same module.
    • Minor imports and helpers added (e.g., VirtualFileUrl, Project, and sharedSourceSetAware).

Written by Cursor Bugbot for commit 135177a. This will update automatically on new commits. Configure here.

@HackerMadCat HackerMadCat self-assigned this Dec 15, 2025
@nskvortsov
Copy link
Contributor

Please add test covering this change

@nskvortsov nskvortsov added the Waiting for Reply The author needs to provide additional details requested by IntelliJ IDEA developers label Dec 16, 2025
Change-Id: I7a791427d706be516c871afddd53aa122e5e7c97
Change-Id: I311208965d4eaf08386b2c8b2500abe357112938
@akerimsenol
Copy link
Contributor Author

Added test cases in GradleJpsSyncExtensionTest. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for Reply The author needs to provide additional details requested by IntelliJ IDEA developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants