IJPL-223825 Keep URLs if it still exists in the storage #3343
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@akerimsenol, Hello, thank you for the PR. Could you please add a test to |
Contributor
|
Please add test for this fix. |
nskvortsov
added
the
Waiting for Reply
Change-Id: I31cf690cac4b2aaf302ad351cbac1e2e97a13f55
akerimsenol
force-pushed
the
fixBaseProjectDirectories
branch
from
e7df492 to
a9d7690
Compare
Contributor
Author
|
Added a test case in BaseProjectDirectoriesTest, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adjusts base directory removal to consult the workspace model URL index, only removing roots whose URLs are no longer referenced.
BaseProjectDirectoriesImpl.kt):updateTreeAndFireChanges, remove old roots fromvirtualFilesTreeonly ifstorageAfter.getVirtualFileUrlIndex().findEntitiesByUrl(it.toVirtualFileUrl(project.workspaceModel.getVirtualFileUrlManager()))returns empty.Written by Cursor Bugbot for commit e7df492. This will update automatically on new commits. Configure here.