jewel: get rid of Jewel JPS artifacts #3340
Open
+159
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalupov
force-pushed
the
leonid.shalupov/IJI-3197-jps-jewel-artifacts
branch
from
3d205d8 to
360b418
Compare
rock3r
reviewed
Dec 11, 2025
Comment on lines
+19
to
+20
| 7. Add the [`detekt-compose.jar`](../../../out/bazel-bin/libraries/detekt-compose-rules/detekt-compose-rules-binary_deploy.jar) file as a plugin | ||
| 8. Add the [`detekt-plugin-binary_deploy.jar`](../../../out/bazel-bin/platform/jewel/detekt-plugin/detekt-plugin-binary_deploy.jar) |
Collaborator
There was a problem hiding this comment.
Any chance we can add a copy action to the build to keep the paths the same? I.e., once it's built, copy the jar to this folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're switing to Bazel, so JPS artifacts will be unavailable, but in this case detekt plugins are easily built by Bazel
Note
Removes IDEA JPS detekt artifacts, adds Bazel binaries for detekt plugin and compose rules, refactors Kotlin compiler deps, and updates setup docs.
intellij_libraries_detekt_compose_rules_jar.xmlandintellij_platform_jewel_detektPlugin_jar.xml.java_binarytargets to produce plugin jars:platform/jewel/detekt-plugin:detekt-plugin-binary(_deploy)with excludes.libraries/detekt-compose-rules:detekt-compose-rules-binary(_deploy).lib/BUILD.bazelto avoid bundling stdlib/coroutines; introduceplatform-jewel-detekt_plugin-jetbrains-kotlin-compiler-embeddableand relatedjvm_imports.MODULE.bazel/lib/BUILD.bazelhttp_file/jvm_import entries (move/add Kotlin compiler, daemon, trove4j) and adjust exports for detekt api/core/test.intellij.platform.jewel.detektPlugin.imlto use a dedicated Kotlin compiler embeddable library and exclude stdlib/coroutines from detekt deps.platform/jewel/detekt-libs/updating-rules.mdwith Bazel build steps for plugin and rules jars.Written by Cursor Bugbot for commit 360b418. This will update automatically on new commits. Configure here.