IDEA-382146 Change parent disposable for build progress listener #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having consoleView as a parent disposable here results in a bug that if that consoleView (tests run window) is closed no further events, including FinishBuildEvent, are propagated tobuildViewManager. This results build tu stuck in 'running' state on the UI. Having buildViewManager as a parent disposable makes more sense here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having consoleView as a parent disposable here results in a bug that if that consoleView (tests run window) is closed no further events, including FinishBuildEvent, are propagated tobuildViewManager. This results build tu stuck in 'running' state on the UI.
Having buildViewManager as a parent disposable makes more sense here.
Note
Switches the build event listener’s parent disposable from the console view to the BuildViewManager to avoid premature disposal when the test console closes.
GradleTestsExecutionConsoleManager.java):DisposablewithbuildViewManageras parent instead ofconsoleViewfor the build event listener.FinishBuildEvent.Written by Cursor Bugbot for commit 36827e6. This will update automatically on new commits. Configure here.