Conversation
pjBooms
reviewed
Apr 5, 2024
| * @param path The path of the file in the compose resource's directory. | ||
| * @return The URI string of the file. | ||
| */ | ||
| public fun getUri(path: String): String = getResourceUri("" + path) |
Contributor
There was a problem hiding this comment.
Should not we add test that calls getUri (we may check that resulting URI contains original path)?
Member
Author
There was a problem hiding this comment.
original path depends on a platform. so we need to call the same logic in the test, it means the test will do nothing
pjBooms
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public
Res.getUri(path: String): Stringfunction.It lets external libraries a way to read resource files by a platform dependent Uri.
E.g.: video players, image loaders or embedded web browsers.
fixes #4360