Option to pack jars as uber JAR, support Proguard for uber JAR#4136
Merged
igordmn merged 7 commits intoJetBrains:masterfrom Apr 12, 2024
Merged
Option to pack jars as uber JAR, support Proguard for uber JAR#4136igordmn merged 7 commits intoJetBrains:masterfrom
igordmn merged 7 commits intoJetBrains:masterfrom
Conversation
Member
|
@badmannersteam could you add integration tests for that? |
Contributor
Author
|
@terrakok probably yes, but what configuration combinations they should check? |
Member
|
I would expect a multi-module project + proguard as uberjar and a regular multi-module project |
badmannersteam
commented
Feb 1, 2024
...rc/main/kotlin/org/jetbrains/compose/desktop/application/internal/configureJvmApplication.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Added some tests. |
Contributor
Author
|
@terrakok seems like that all for now. |
Contributor
Author
|
I'll check the tests today and also want to fix the issue on Windows, that was mentioned above (by flattering into the intermediate jar instead of directory). |
Member
|
@badmannersteam could you check failed tests and rebase the branch on top of the master? |
…e' tasks now depend on Proguard.
80bcfc8 to
7fe647f
Compare
Contributor
Author
|
@terrakok all done. |
terrakok
approved these changes
Mar 13, 2024
Contributor
Author
|
@igordmn, look at this pls :) |
Contributor
Author
Collaborator
|
Most probably yes, it will be in the next release (1.6.10). I plan to review it soon. |
igordmn
approved these changes
Apr 12, 2024
Collaborator
igordmn
left a comment
There was a problem hiding this comment.
Thanks!
LGTM.
Few things:
- I changed the title/description by our new PR format
- I moved README to support/1.6.10, which will be merged to
masteron the release date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing
A new auto test
Manual:
joinOutputJars:false(by default) should generate multiple jars (except forpackage*UberJarForCurrentOS)trueshould generate a single jar in a result distribution3. Test debug tasks:
The jars should be reduced in size (because Proguard is enabled in the release mode)
This should be test by QA.
Issues fixed
Fixes #4129