Add accounting_noise_multiplier property for correct privacy accounting#12
Merged
david-stan merged 1 commit intojbr-mainfrom Jan 29, 2026
Merged
Conversation
…ting AdaClipDPOptimizer internally adjusts `noise_multiplier` based on Theorem 1 from https://arxiv.org/pdf/1905.03871.pdf. However, the accountant hook was reading this adjusted value instead of the original user-provided value, leading to incorrect privacy budget calculations. This fix introduces an `accounting_noise_multiplier` property: - DPOptimizer: returns `self.noise_multiplier` (default behavior) - AdaClipDPOptimizer: overrides to return the original value The accountant hook now uses this property, ensuring correct privacy accounting regardless of optimizer implementation details. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 21488317796Details
💛 - Coveralls |
david-stan
added a commit
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdaClipDPOptimizer internally adjusts
noise_multiplierbased on Theorem 1 from https://arxiv.org/pdf/1905.03871.pdf. However, the accountant hook was reading this adjusted value instead of the original user-provided value, leading to incorrect privacy budget calculations.This fix introduces an
accounting_noise_multiplierproperty:self.noise_multiplier(default behavior)The accountant hook now uses this property, ensuring correct privacy accounting regardless of optimizer implementation details.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist