Skip to content

feat: added integration with kotlinx.serialization#76

Merged
AbdullinAM merged 1 commit intoJetBrains-Research:mainfrom
y9san9:main
Jul 15, 2025
Merged

feat: added integration with kotlinx.serialization#76
AbdullinAM merged 1 commit intoJetBrains-Research:mainfrom
y9san9:main

Conversation

@y9san9
Copy link
Contributor

@y9san9 y9san9 commented Jun 30, 2025

For the past two weeks I played around with kotlinx.fuzz and that's when I got the idea to make an integration with kotlinx.serialization. So, I made this PR. This PR doesn't yet contain full documentation on every type that I wrote, but if you are interested in merging that to the upstream, I am glad to provide one.

I recommend checking this README out before reading through PR: https://github.com/y9san9/kotlinx.fuzz/tree/main/kotlinx.fuzz.serialization/README.md

@y9san9 y9san9 force-pushed the main branch 3 times, most recently from 6b1ccdc to a755a59 Compare June 30, 2025 20:09
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ktlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@AbdullinAM
Copy link
Member

Hey @y9san9! Sorry for the late reply!

This is an amazing idea and a great implementation! Thank you!
I will be happy to merge it to upstream. May I ask you to fix the linter issues, please? From what I see you can just run ./gradlew diktatFix locally an it should automatically fix all the problems.

@y9san9
Copy link
Contributor Author

y9san9 commented Jul 15, 2025

@AbdullinAM There is one problem here. I don't think this class should be a data class since it's full of lambdas

Screenshot 2025-07-15 at 18 44 21

So that's what I did ATM:

Screenshot 2025-07-15 at 18 45 41

Everything else is fixed.

Also I don't know if you mind that I am force pushing to keep commits clean, or I should leave all the commits for easier review.

@AbdullinAM
Copy link
Member

@y9san9 Thanks!

Yeah, I think for this case we can ignore the linter warnings. As for the force pushes --- thats totally fine 😃. I think having all changes in one commit will be beneficial for the future

@y9san9
Copy link
Contributor Author

y9san9 commented Jul 15, 2025

Looks like we have to declare a new dependency somehow (kotlinx.serialization)

@AbdullinAM
Copy link
Member

@y9san9 I think we can just ignore it. I planned to turn off dependency submission and reconfigure CI anyways.

Thank you for your contribution! I will merge the PR

@AbdullinAM AbdullinAM merged commit 3901a4c into JetBrains-Research:main Jul 15, 2025
8 of 9 checks passed
@y9san9
Copy link
Contributor Author

y9san9 commented Jul 15, 2025

Thank you for your time! I hope it's not the last time me contributing to the Kotlin Ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants