-
Notifications
You must be signed in to change notification settings - Fork 6
config refactoring #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
97456f5
config prototype
DLochmelis33 53b10cf
support splitting into files
DLochmelis33 b149333
get DSL working with delegates to delegates
DLochmelis33 698c412
migrate project to new config settings
DLochmelis33 4a31b1d
rename to original + pass tests
DLochmelis33 75412a1
fix tests
DLochmelis33 f88340e
comply with diktat
DLochmelis33 96c1ae3
fix naming
DLochmelis33 8979a93
merge with 'main' updates
DLochmelis33 fa5278b
fix merge issues
DLochmelis33 30b764f
cleanup and add comments
DLochmelis33 e260ed1
small fix
DLochmelis33 e7ae5e2
support project properties in config DSL
DLochmelis33 37395f6
small fix, run all tests
DLochmelis33 7a7538c
PR review fixes
DLochmelis33 bed48d3
merge main updates
DLochmelis33 26ce0a3
fix main updates
DLochmelis33 44f3743
a
DLochmelis33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
268 changes: 0 additions & 268 deletions
268
kotlinx.fuzz.api/src/main/kotlin/kotlinx/fuzz/KFuzzConfig.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 0 additions & 24 deletions
24
kotlinx.fuzz.api/src/main/kotlin/kotlinx/fuzz/SystemProperty.kt
This file was deleted.
Oops, something went wrong.
27 changes: 27 additions & 0 deletions
27
kotlinx.fuzz.api/src/main/kotlin/kotlinx/fuzz/config/CoverageConfig.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package kotlinx.fuzz.config | ||
|
|
||
| private const val NAME_PREFIX = "coverage" | ||
|
|
||
| interface CoverageConfig { | ||
| val reportTypes: Set<CoverageReportType> | ||
| val includeDependencies: Set<String> | ||
| } | ||
|
|
||
| class CoverageConfigImpl internal constructor(builder: KFuzzConfigBuilder) : CoverageConfig { | ||
| override var reportTypes: Set<CoverageReportType> by builder.KFuzzPropProvider( | ||
| nameSuffix = "$NAME_PREFIX.reportTypes", | ||
| intoString = { it.joinToString(",") }, | ||
| fromString = { it.split(",").map { CoverageReportType.valueOf(it) }.toSet() }, | ||
| default = setOf(CoverageReportType.HTML), | ||
| ) | ||
| override var includeDependencies: Set<String> by builder.KFuzzPropProvider( | ||
| nameSuffix = "$NAME_PREFIX.includeDependencies", | ||
| intoString = { it.joinToString(",") }, | ||
| fromString = { it.split(",").toSet() }, | ||
| default = emptySet(), | ||
| ) | ||
| } | ||
|
|
||
| enum class CoverageReportType { | ||
| CSV, HTML, XML; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, we should move
instrumentandcustomHookExcludesfromTargetConfigtoGlobalConfig. I can't see reasons to instrument different classes depending on target (we could instrument only the code we execute, but it's a different thing). Same forcustomHookExcludes: if we want to exclude something, we most likely want to exclude it everywhereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that I fully agree with that. I think there might be reasons to want to instrument different parts of code for different targets. Because depending on what is instrumented, fuzzer will change its behaviour. So if I want a target to fuzz a specific part of the project, I would want to "communicate" that idea to the fuzzer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it makes more sense to have
customHookINCLUDESfor some targets and others not. But this is again a question about borrowing Jazzer naming. Will remove these two from@KFuzzTestarguments as well