Merged
Conversation
AbdullinAM
requested changes
Jan 8, 2025
AbdullinAM
requested changes
Jan 9, 2025
Member
AbdullinAM
left a comment
AbdullinAM
left a comment
There was a problem hiding this comment.
Overall everything is good, and it's great that you were able to provide a KFuzzImpl that is not dependent on the fuzz engine.
There are several code style related issues that need to be fixed.
Also, I think we need to add at least some unit tests for KFuzzImpl, to ensure there are no obvious problems with the implementation
AbdullinAM
requested changes
Jan 10, 2025
Member
AbdullinAM
left a comment
AbdullinAM
left a comment
There was a problem hiding this comment.
Just a couple of fixes for the tests and otherwise everything is ready
AbdullinAM
added
change resuested
FerrumBrain
added
ready for review
AbdullinAM
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.