-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Documentation improvements 21-10-24 #4878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements 21-10-24 #4878
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6bc1f57:
|
@@ -2,10 +2,12 @@ import React, { Component, Fragment } from 'react'; | |||
|
|||
import Select from 'react-select'; | |||
import { colourOptions } from '../data'; | |||
import { Note } from '../styled-components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove it from the 4 other examples that use it? Not necessary, but seems like a nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Note
component only seems to be used as a label. I think it might be more straight forward to import the style than the styled component but curious if there were other thoughts on keeping the label elements styled consistently (assuming it's a concern).
This is a WIP to address several issues with the documentation site.
Thus far this address the following issues:
StyledSingle
example so the dot color matches the selected colo(u)r value as intendedBasicSingle
example and remove dependency ofstyled-components
which results in broken dependency when trying to view in CodeSandbox