Skip to content

Documentation improvements 21-10-24 #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ebonow
Copy link
Collaborator

@ebonow ebonow commented Oct 26, 2021

This is a WIP to address several issues with the documentation site.

Thus far this address the following issues:

  • Improve accessibility by applying outline to focused buttons to view source and codesandbox link and remove unnecessary state management of original implementation.
  • Fix StyledSingle example so the dot color matches the selected colo(u)r value as intended
  • Simplify the BasicSingle example and remove dependency of styled-components which results in broken dependency when trying to view in CodeSandbox

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2021

⚠️ No Changeset found

Latest commit: 6bc1f57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6bc1f57:

Sandbox Source
react-codesandboxer-example Configuration

@@ -2,10 +2,12 @@ import React, { Component, Fragment } from 'react';

import Select from 'react-select';
import { colourOptions } from '../data';
import { Note } from '../styled-components';
Copy link
Collaborator

@Methuselah96 Methuselah96 Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove it from the 4 other examples that use it? Not necessary, but seems like a nice to have.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Note component only seems to be used as a label. I think it might be more straight forward to import the style than the styled component but curious if there were other thoughts on keeping the label elements styled consistently (assuming it's a concern).

@JedWatson JedWatson enabled auto-merge October 28, 2021 22:39
@JedWatson JedWatson merged commit e67ea16 into JedWatson:master Oct 28, 2021
@ebonow ebonow deleted the documentation-improvements-21-10-24 branch October 28, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants