Skip to content

Access updates #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

TheHollidayInn
Copy link

While reviewing #4161, I thought it might be a good idea to add an example in the documentation. Let me know if this is wanted.

Also, I'm sorry, but I could not find radegran's repo when trying to assign the base repository. So, I just made the PR on to master. Please merge #4161 first, then the commits should clear up.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2020

💥 No Changeset

Latest commit: ba2fc6f

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba2fc6f:

Sandbox Source
react-codesandboxer-example Configuration

@bladey bladey added category/documentation Issues or PRs about documentation or the website itself pr/enhancement PRs that are specifically enhancing the project pr/needs-review PRs that need to be reviewed to determine outcome labels Oct 1, 2020
@ebonow ebonow added this to the 3.3 milestone Jan 15, 2021
@Methuselah96
Copy link
Collaborator

@TheHollidayInn There are merge conflicts that need to be resolved.

@ebonow
Copy link
Collaborator

ebonow commented Jan 21, 2021

Greetings @TheHollidayInn,

Thank you for your efforts creating this example to go with #4161. Your efforts are much appreciated. Since the PR you created was in conjunction with #4161 and that PR was closed in favor of one that could updated, I will be closing this as well. Please note that I have taken most of the work you have provided here and merged it into #4390 with some minor changes, but all in all, the work you provided was very helpful.

Your efforts are appreciated and look forward to moving forward with some long over due updates to aria live messaging. Please feel free to add any feedback to #4390 and if you see any other opportunities for feedback, please feel free to let me know there.

Thank you again!

@ebonow ebonow closed this Jan 21, 2021
@ebonow ebonow mentioned this pull request Jan 21, 2021
@ebonow ebonow removed this from the 4.1 milestone Jan 22, 2021
@ebonow ebonow mentioned this pull request Feb 1, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/documentation Issues or PRs about documentation or the website itself pr/enhancement PRs that are specifically enhancing the project pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants