Skip to content

Flow updates #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2019
Merged

Flow updates #3537

merged 7 commits into from
Oct 2, 2019

Conversation

jdelStrother
Copy link
Contributor

I was running into flow difficulties using Async & AsyncCreatable - their HOC functions were losing the defaultProps of the components, so, eg:

<Async loadOptions={loadOptions} />

would complain with the following:

Cannot create Async element because:
 • property cacheOptions is missing in props [1] but exists in AsyncProps [2].
 • property defaultOptions is missing in props [1] but exists in AsyncProps [2].
 • property onInputChange is missing in props [1] but exists in AsyncProps [2].

WDYT to this?

I've also changed a couple of string types to React$Node - the children of SingleValue, and the return value from noOptionsMessage. There shouldn't be any functional code changes, just type changes.

@mufasa71
Copy link
Contributor

mufasa71 commented May 4, 2019

@jdelStrother I did almost the same here #3538 😄

@jdelStrother
Copy link
Contributor Author

@JedWatson anything that me/mufasa71 can do to help get either of these merged? I'll fix my merge conflicts if you're intending to merge this.

@emmatown emmatown self-requested a review October 2, 2019 08:32
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2019

🦋 Changeset is good to go

Latest commit: 87de86e

We got this.

Not sure what this means? Click here to learn what changesets are.

@emmatown emmatown mentioned this pull request Oct 2, 2019
Copy link
Collaborator

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants