onMenuOpen triggers on each input

[kino90]

When a select (or creatable) is open, writing triggers onMenuOpen callback on each keystroke.

Demo: https://codesandbox.io/s/k0l8r2z6yr

I think that it should only trigger when opening the menu, right?

[ronjouch]

When a select (or creatable) is open, writing triggers onMenuOpen callback on each keystroke.

Demo: https://codesandbox.io/s/k0l8r2z6yr

I think that it should only trigger when opening the menu, right?

I confirm the bug with react-select@2.4.1 in Chrome 72

[Bryze]

Any update on this?

[viniciusdacal]

still on 3.0.4.

The Select component is calling parent props onMenuOpen.
I imagine that's because the expected behaviour is that the menu should be always open
if the user is typing.
However, we could put a condition in the manger, or in the select, if the menu is already open, there's no reason to fire onMenuOpen again.

[lorisdev]

Still the same behavior in 3.0.8

The onMenuOpen callback is triggered within handleInputChange in addition of being triggered already when the Menu actually opens in the openMenu method as is has been mentioned in #3620 as well

react-select/packages/react-select/src/Select.js

Line 1092 in 3c7de0d

this.onMenuOpen();

react-select/packages/react-select/src/Select.js

Line 502 in 3c7de0d

this.onMenuOpen();

[lorisdev]

Well just removing the call to onMenuOpen inside handleInputChange breaks some tests ... Looks like the lib is relying on this buggy behaviour for a reason I don't have time to investigate ...
Thus it may be a breaking change for many users and may require a major new version...

[lorisdev]

pruik found that we should call onMenuOpen inside handleInputChange #3897 (comment)

The PR now passes all the test 🎉
He proposed another PR as well which fixes this bug. We may see it fixed soon 🤞