fix: check against 'main' function name instead of entrypoint function #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update docs to be a bit more clear
Jared-Prime
approved these changes
Jul 7, 2025
| use rustc_hir::{Expr, ExprKind, Item, ItemKind, OwnerNode}; | ||
| use rustc_lint::{LateContext, LateLintPass, LintContext}; | ||
| use rustc_session::declare_lint_pass; | ||
| use rustc_span::sym; | ||
|
|
||
| declare_clippy_lint! { | ||
| /// ### What it does | ||
| /// Detects calls to the `exit()` function which terminates the program. | ||
| /// Detects calls to the `exit()` function that are not in the `main` function. Calls to `exit()` |
| /// | ||
| /// fn other_function() { | ||
| /// std::process::exit(0); | ||
| /// } |
| @@ -36,7 +49,7 @@ declare_clippy_lint! { | |||
| #[clippy::version = "1.41.0"] | |||
| pub EXIT, | |||
| restriction, | |||
| "detects `std::process::exit` calls" | |||
| "detects `std::process::exit` calls outside of `main`" | |||
There was a problem hiding this comment.
Thanks for the clarifications!
| // if you instead check for the parent of the `exit()` call being the entrypoint function, as this worked before, | ||
| // in compilation contexts like --all-targets (which include --tests), you get false positives | ||
| // because in a test context, main is not the entrypoint function | ||
| && ident.name.as_str() != "main" |
There was a problem hiding this comment.
OK... so we need to get the identity of the "next item up", inspect its literal name, and check that it's not named "main". Moreover, we're saying this avoids the false positive described by rust-lang#13358
I think I get it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Jared-Prime!
Here's a quick PR to update your PR with the updates suggested by
y21in your PR.This changes it to:
main--testflag to ensure this works correctly regardless of compilation context