Skip to content

Support Task Configuration Avoidance - #1445

Open
stephanenicolas wants to merge 2 commits into
JakeWharton:masterfrom
stephanenicolas:sni/issue-1440-use-lazy-tasks
Open

Support Task Configuration Avoidance#1445
stephanenicolas wants to merge 2 commits into
JakeWharton:masterfrom
stephanenicolas:sni/issue-1440-use-lazy-tasks

Conversation

@stephanenicolas

@stephanenicolas stephanenicolas commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Solves issue #1440. The change is limited.

  • delay the creation of the processResourcesTask used in the generateR2 task.
  • the generate R2 task itself still has to be created (because AGP doesn't allow to pass it as a task provider, I created a ticket for that).

stephanenicolas
stephanenicolas commented Jan 31, 2019
View reviewed changes
Comment thread butterknife/src/main/AndroidManifest.xml
@@ -1,2 +1 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="butterknife"/>
<manifest package="butterknife.core"/>

@stephanenicolas stephanenicolas Jan 31, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a side effect of upgrading the AGP version, it looks like single word package names are not allowed anymore. But I don't think it has any impact.

@JakeWharton JakeWharton Jan 31, 2019

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by https://issuetracker.google.com/issues/73450622

@stephanenicolas stephanenicolas Feb 1, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of the change of the manifest ?

@ZacSweers ZacSweers mentioned this pull request Feb 8, 2019
Closed
@stephanenicolas
stephanenicolas force-pushed the sni/issue-1440-use-lazy-tasks branch from 9913d77 to 4387cf1 Compare February 9, 2019 23:52
stephanenicolas
stephanenicolas commented Feb 9, 2019
View reviewed changes
Comment thread build.gradle
'androidTools': '26.2.0',
'kotlin': '1.2.71',

'kotlin': '1.3.11',

@stephanenicolas stephanenicolas Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version of kotlin is not the latest, but it is recommended in AS 3.3.0 that goes with AGP 3.3.0

@stephanenicolas

stephanenicolas commented Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

The PR has been rebased against current master, I squashed my commits, it should now get green. The kotlin version better matches Android Studio.

@stephanenicolas

stephanenicolas commented Feb 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I just realized I was missing an obsolete call. I fixed it in a second commit.
I couldn't figure out exactly how to test it.

Please test it properly or let me know how to make sure the original behavior works fine.

@stephanenicolas

stephanenicolas commented Feb 10, 2019

Copy link
Copy Markdown
Contributor Author

I've tested the second commit too and all seems to be working pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeWharton JakeWharton JakeWharton left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephanenicolas @JakeWharton