Skip to content

Initial macOS port #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial macOS port #6

wants to merge 1 commit into from

Conversation

mrexodia
Copy link

image

These changes are just enough to make things compile (your last commit also broke the .json.in detection so I had to move that). Unfortunately it looks like backspace/delete is not working and neither are the arrows. I don't know anything about macOS though, so maybe someone else will come along and improve it. If you have suggestions on how to debug this I am also open to try it.

@JakeSays
Copy link
Owner

@mrexodia Hey I appreciate the PR, but I am going to hold off on merging it until I have the capacity to build/test locally.

@mrexodia
Copy link
Author

Sure! Like I said, this doesn’t actually work but it at least fixes the build. I made sure these changes are only for macOS, on Linux everything should work the same.

I would encourage you to consider merging them anyway after you confirmed this doesn’t affect the Linux build. Otherwise things will probably desynchonize…

@JakeSays
Copy link
Owner

I am planning on doing a ton of cleanup to remove all of the KDE code that isn't actually being used, and then add a proper configuration dialog. I'll merge this in before doing that refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants