Initial macOS port #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrexodia Hey I appreciate the PR, but I am going to hold off on merging it until I have the capacity to build/test locally. |
|
Sure! Like I said, this doesn’t actually work but it at least fixes the build. I made sure these changes are only for macOS, on Linux everything should work the same. I would encourage you to consider merging them anyway after you confirmed this doesn’t affect the Linux build. Otherwise things will probably desynchonize… |
|
I am planning on doing a ton of cleanup to remove all of the KDE code that isn't actually being used, and then add a proper configuration dialog. I'll merge this in before doing that refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are just enough to make things compile (your last commit also broke the
.json.indetection so I had to move that). Unfortunately it looks like backspace/delete is not working and neither are the arrows. I don't know anything about macOS though, so maybe someone else will come along and improve it. If you have suggestions on how to debug this I am also open to try it.