Replace numbers and arrays with LEB128 implementations where appropriate #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Use unsigned LEB128 encoding in conjunction with borsh to reduce instruction data overhead for instructions with offsets and lengths called a
CompactU64.Use unsigned LEB128 encoding as length for multi-assertion instructions to reduce overhead from 4 bytes per vector to 1 byte (common case) called a
LEB128Vec.Switch from
Option<u16>toCompactU64for start and length of hash verify for AccountData since offset and length of account data needs to be known in order to hash.