Skip to content

Update typings to support a null access token #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2020
Merged

Update typings to support a null access token #154

merged 1 commit into from
Apr 19, 2020

Conversation

ejunebug
Copy link
Contributor

Currently getAccessToken can return null, so the return type of the method should be string | null, and the typings should probably allow calling setAccessToken(null) as well.

@ejunebug
Update typings to support a null access token
914f2e5 
Currently getAccessToken can return null, so the return type of the method should be `string | null`, and the typings should probably allow calling `setAccessToken(null)` as well.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.396% when pulling 914f2e5 on hankhester:patch-1 into b1e09e9 on JMPerez:master.

@JMPerez JMPerez merged commit f10d2d8 into JMPerez:master Apr 19, 2020
@JMPerez
Copy link
Owner

JMPerez commented Apr 19, 2020

Thank you @hankhester!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejunebug @coveralls @JMPerez