Merged
Conversation
| if (!StringUtils.hasText(loginType)) { | ||
| throw new NullPointerException("로그인 타입이 없습니다."); | ||
| } | ||
| for (OauthService service : oauthServices) { |
Contributor
There was a problem hiding this comment.
return oauthServices.stream() .filter(oauthService -> oauthService.getLoginType().name().equals(loginType)) .findAny() .orElseThrow(() -> new NullPointerException("일치하는 로그인 타입이 없습니다."));
여기 로직을 이렇게 하는건 어떨까요?
|
|
||
| public OauthService getOauthServiceByLoginType(String loginType) { | ||
| if (!StringUtils.hasText(loginType)) { | ||
| throw new NullPointerException("로그인 타입이 없습니다."); |
Contributor
There was a problem hiding this comment.
'로그인 타입이 없습니다.' 보다는 '로그인 타입이 입력되지 않았습니다.' 이렇게 조금 더 명시적으로 하는게 어떨까요?
Jaeyeop-Jung
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
설명
변경사항
질문사항