Merged
Conversation
| ) | ||
| }) | ||
| @PutMapping("/{recordId}") | ||
| public ResponseEntity<Long> updateRecord( |
| private List<String> deleteImages; | ||
|
|
||
| @Builder | ||
|
|
|
|
||
| @Builder | ||
|
|
||
| public UpdateRecordRequestDto(String title, String content, String colorName, String iconName, |
| public void deleteAttachmentFiles( | ||
| @NonNull RefType refType, | ||
| @NonNull Long refId, | ||
| @NonNull List<String> attachmentFileNames) { |
| @NonNull RefType refType, | ||
| @NonNull Long refId, | ||
| @NonNull List<String> attachmentFileNames) { | ||
| imageFileRepository.deleteAllByRefTypeAndRefIdAndSaveNameIsIn(refType, refId, attachmentFileNames); |
Contributor
There was a problem hiding this comment.
이거 쿼리 메소드 SaveNameIsIn할 때 IsIn으로 해야되나요?
- updateRecord -> modifyRecord 로 변경 - UpdateRecordRequestDto -> ModifyRecordRequestDto 로 변경 - 코드 컨벤션 수정 - deleteAllByRefTypeAndRefIdAndSaveNameIsIn -> deleteAllByRefTypeAndRefIdAndSaveNameIn 으로 변경
Jaeyeop-Jung
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
설명
레코드 수정 테스트와 로직 작성하였습니다.
변경사항
질문사항