Fix for issue #455 #458
Merged
Fix for issue #455 #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote UArray comparison functions to use boolean type instead of int type to resolve any ambiguity. Modified signatures of the corresponding functions. Ran tests and checked that they pass: $ LD_LIBRARY_PATH=`pwd`/install/lib/ ../install/bin/io ../libs/iovm/tests/correctness/run.io ...................................................................... ...................................................................... ...................................................................... .................... ---------------------------------------------------------------------- Ran 230 tests in 3.0030000000000001s OK run
|
It fails on format check. Please, run clang-format against it. It also fails on windows, but I can't say whether it introduced by your changes. Could you check, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote UArray comparison functions to use boolean type instead of int type to
resolve any ambiguity. Modified signatures of the corresponding functions.
Ran tests and checked that they pass: