Conversation
… a process passing in the `ApaxCmd` class and a renaming of a library in the `BuildContext` class. 1. **Modification in Process Passing Criteria in `ApaxCmd` Class**: The condition to determine if a process has passed has been updated. Instead of checking for the string "OVERALLRESULT[PASSED]" in the output, the new condition checks for "FAILED:0". This implies that a process is considered successful if there are no failures reported in the output. This change could significantly affect how process outcomes are determined, potentially making the criteria for passing more straightforward or aligned with how results are reported. (File: `ApaxCmd.cs`) 2. **Renaming of Library in `BuildContext` Class**: A library previously known as "ax.axopen.hwlib" has been renamed to "ax.axopen.hwlibrary". This change is limited to the renaming of the library without affecting its packaging status, indicating a possible rebranding or standardization of library names without altering its inclusion in builds or packages. (File: `BuildContext.cs`)
…kaging process, specifically adding a condition for packaging in the build process, removing unnecessary code, and enhancing logging for better visibility of the build flow. These changes aim to improve the flexibility and maintainability of the codebase. 1. **Packaging Condition Added to Test and Build Process**: A new conditional check has been introduced in the `TestsTask` class to determine whether packaging steps should be executed based on the `DoPack` parameter. This allows for more flexible build configurations by only including packaging steps when necessary. [Reference: TestsTask class, conditional check for `context.BuildParameters.DoPack`] 2. **Removed Unnecessary Closing Bracket**: An extraneous closing bracket has been removed, likely fixing a syntax error or improving code readability. This minor change contributes to cleaner and more maintainable code. [Reference: Removal of unnecessary closing bracket after exception throw statement] 3. **Commented Out Code in CreateArtifactsTask**: Sections of code in the `CreateArtifactsTask` class have been commented out, including a block that changes build properties for Apax files and the call to `PackApax(context);`. This indicates a possible shift in packaging strategy or a temporary measure for debugging or refactoring. [Reference: Commented out code in `CreateArtifactsTask` class] 4. **Warning for Skipping Packaging**: A warning has been added to the build process to notify when the packaging step is skipped due to the `DoPack` parameter being false. This enhances the transparency of the build process by making it clear when certain steps are omitted based on build parameters. [Reference: Warning log addition for skipped packaging process]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update AXOpen to '@ax/simatic-ax@2405.0.0'.
Direct
axdependencies were removed from the libraries and testing applications.axdependencies are now grouped into the following projects: