ouroboros-network-0.21.1.0 #5127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/ouroboros-network-0.21.1
branch
from
35e3f15 to
0f27b8d
Compare
crocodile-dentist
approved these changes
May 26, 2025
coot
force-pushed
the
coot/ouroboros-network-0.21.1
branch
from
0f27b8d to
24100f8
Compare
9 tasks
A race can occur between peerMonitoringLoop closing an outbound connection due to a warm protocol finish and the OG demoting the same peer for different reason. Both will call closePeerConnection, but only the winner should invoke CM's releaseOutboundConnection. If the winner is the OG's demotion job, close peer connection should not return wasWarm, because the losing peerMonitoringLoop would see it as false, and would end without setting peer status variable to PeerCold. Instead, the return value of closePeerConnection is changed such that the it will work regardless of who wins the race to close the outbound connection.
coot
force-pushed
the
coot/ouroboros-network-0.21.1
branch
from
24100f8 to
9d18722
Compare
coot
force-pushed
the
coot/ouroboros-network-0.21.1
branch
from
9d18722 to
f0c3f7e
Compare
coot
force-pushed
the
coot/ouroboros-network-0.21.1
branch
from
f0c3f7e to
3477ed9
Compare
coot
force-pushed
the
coot/ouroboros-network-0.21.1
branch
from
3477ed9 to
92a9487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Quality
Maintenance
ouroboros-networkproject.