-
Notifications
You must be signed in to change notification settings - Fork 30
Integration with ouroboros-network:cardano-diffusion #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
MustExist -> | ||
-- create the file if it doesn't exist | ||
void $ | ||
hPut hasFS pHnd $ | ||
Put.execPut $ | ||
Put.putWord8 currentVersionNumber | ||
<> putSecondaryOffset 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right?
...onsensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Index/Cache.hs
Show resolved
Hide resolved
65e4a5d
to
b6e8b42
Compare
ouroboros-network-protocols | ||
ouroboros-network-testing | ||
|
||
source-repository-package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for an s-r-p on fs-sim
, this revision is already on Hackage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed before merging
b6e8b42
to
24b6918
Compare
24b6918
to
d24a4aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Golden files are out-of-date too.
ouroboros-network-protocols | ||
ouroboros-network-testing | ||
|
||
source-repository-package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed before merging
@@ -15,7 +15,6 @@ import qualified Ouroboros.Network.AnchoredFragment as AF | |||
import Ouroboros.Network.Driver.Limits | |||
( ProtocolLimitFailure (ExceededTimeLimit) | |||
) | |||
import Ouroboros.Network.Protocol.ChainSync.Codec (mustReplyTimeout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised we can delete these imports without deleting any code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ChainSyncTimeout
data type is now defined in Test.Consensus.PointSchedule
.
-- [ canAwaitTimeout cst | ||
-- , intersectTimeout cst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be uncommented.
] | ||
) | ||
let | ||
-- cst = gtChainSyncTimeouts gt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
...onsensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Index/Cache.hs
Show resolved
Hide resolved
@@ -424,6 +424,13 @@ open hasFS@HasFS{hOpen, hClose} chunk allowExisting = do | |||
flip onException (hClose pHnd) $ do | |||
case allowExisting of | |||
AllowExisting -> return () | |||
MustExist -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems fine as is, and also we never call this function with that argument
Also obsoletes #1561 |
d24a4aa
to
ac84a32
Compare
Closes #1527
Description