Refactor cardanoTestnet to no longer use GenesisOptions
#6315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbacquey
force-pushed
the
nb/refactor_genesis
branch
2 times, most recently
from
f6c0b83 to
a2c71dc
Compare
nbacquey
force-pushed
the
nb/remove_broken_link
branch
from
20c8407 to
46cbb65
Compare
nbacquey
force-pushed
the
nb/refactor_genesis
branch
from
a2c71dc to
924729e
Compare
Jimbo4350
reviewed
Aug 27, 2025
carbolymer
reviewed
Aug 27, 2025
Since `createTestnetEnv` is now responsible for creating the sandbox environment, `cardanoTestnet` no longer needs Genesis information. This commit removes the dependency, and gets the needed information from the sandbox environment instead.
nbacquey
force-pushed
the
nb/refactor_genesis
branch
from
924729e to
205c733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
createTestnetEnvis now responsible for creating the sandbox environment,cardanoTestnetno longer needs Genesis information. This commit removes the dependency, and gets the needed information from the sandbox environment instead.Checklist
hlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12