Skip to content

Introduce flag in cardano-testnet create-env to update time stamps #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: nb/refactor_topology
Choose a base branch
from

Conversation

nbacquey
Copy link
Contributor

@nbacquey nbacquey commented Jul 7, 2025

Description

This PR adds a helper to avoid manually updating time stamps in byron-genesis.json and shelley-genesis.json before starting a testnet with a modified configuration

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • integration tests
  • Any changes are noted in the CHANGELOG.md for affected package
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@nbacquey nbacquey changed the base branch from master to nb/refactor_topology July 7, 2025 12:05
@nbacquey nbacquey marked this pull request as ready for review July 7, 2025 13:32
@nbacquey nbacquey requested a review from a team as a code owner July 7, 2025 13:32
@nbacquey nbacquey force-pushed the nb/refactor_topology branch from c4b928c to 38db4bf Compare July 7, 2025 14:09
@nbacquey nbacquey force-pushed the nb/testnet_update_date branch from f26d61c to 6dfd31d Compare July 7, 2025 14:28
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I think this should exist as a separate command. We have experience with this in cardano-cli where too many flags are added to a single command making it unwieldly.

@Jimbo4350 Jimbo4350 self-requested a review July 9, 2025 14:18
@nbacquey nbacquey force-pushed the nb/testnet_update_date branch from 448dd57 to 84629f1 Compare July 9, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants