1641 - config can override presets #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
1641-config-overide-presets
branch
3 times, most recently
from
9857461 to
6e365ef
Compare
sgillespie
reviewed
Jul 19, 2024
sgillespie
reviewed
Jul 19, 2024
| case insertOpts of | ||
| FullInsertOptions -> | ||
| case insertCfg of | ||
| SyncInsertConfig (Just "full") _ -> |
There was a problem hiding this comment.
These would be nicer to use as ADTs (rather than strings), as I mentioned in my other comment. It would also make the wildcard clause unnecessary
sgillespie
reviewed
Jul 19, 2024
sgillespie
requested changes
Jul 19, 2024
Cmdv
force-pushed
the
1641-config-overide-presets
branch
2 times, most recently
from
4917bbe to
10e3375
Compare
Cmdv
force-pushed
the
1641-config-overide-presets
branch
from
10e3375 to
e833345
Compare
sgillespie
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1641
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.