fix: add dummy_prefill guard for PD connection operations #3803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation attempts to call
shelf_prefill_session
on the PD (Prefill-Decode) connection pool regardless of whether dummy prefill mode is enabled. However, whendummy_prefill
is set to True, there is no actual prefill session migration happening, and attempting to shelf a non-existent prefill session can lead to unnecessary operations or potential errors.Modification
Added conditional guards around
node_manager.pd_connection_pool.shelf_prefill_session()
calls in two API endpoints:/v1/chat/completions endpoint
[chat_completions_v1]:Added
if not node_manager.dummy_prefill:
guard before callingshelf_prefill_session
/v1/completions endpoint
[completions_v1]: Addedif not node_manager.dummy_prefill:
guard before callingshelf_prefill_session
Checklist