Skip to content

Pass correct linkage_name attribute to DIBuilder #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 14, 2021
Merged

Pass correct linkage_name attribute to DIBuilder #434

merged 14 commits into from
Jun 14, 2021

Conversation

vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Jun 9, 2021 •
edited by PokhodenkoSA
Loading

New file created dppy_debuginfo.py with the DPPYDIBuilder class.
DPPYDIBuilder modifies mark_subprogram method and passes correct name to linkage_name attribute.

New ModifiedLower class contains the constructor needed to create an instance of DPPYDIBuilder class.

Tests:

  • IR contains DISubprogram with function linkageName without ID
  • IR contains DICompileUnit with DW_LANG_C_plus_plus
  • IR contains DICompileUnit with producer = numba-dppy

Changes:

  • Removed ModifiedLower. DPPYLower adjusts standard Lower.

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jun 9, 2021
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Jun 9, 2021
Closed
3 tasks
PokhodenkoSA
PokhodenkoSA suggested changes Jun 9, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA reviewed Jun 10, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA reviewed Jun 10, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests and code cleanup.

@PokhodenkoSA PokhodenkoSA merged commit 3e07822 into IntelPython:main Jun 14, 2021
@PokhodenkoSA PokhodenkoSA mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

@1e-to 1e-to Awaiting requested review from 1e-to

@akharche akharche Awaiting requested review from akharche

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
2 - Ready for Review debug Related to #149
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @PokhodenkoSA