Skip to content

Fix dpnp.ndarray constructor call with buffer passed as data property #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2025
Merged

Fix dpnp.ndarray constructor call with buffer passed as data property #2533

merged 4 commits into from
Jul 21, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 21, 2025 •
edited
Loading

The PR closes gh-2532.

In the faulty example the buffer was passed with .data of dpnp.ndarray. In that case there is no need to cast dpctl's usm_data to DPNP memory object.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 21, 2025
@antonwolfy antonwolfy self-assigned this Jul 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_18 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.095% (+0.003%) from 72.092%
when pulling d507e20 on resolve-gh-2532
into 81870b7 on master.

vtavana
vtavana approved these changes Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 307fc66 into master Jul 21, 2025
119 of 121 checks passed
@antonwolfy antonwolfy deleted the resolve-gh-2532 branch July 21, 2025 14:26
github-actions bot added a commit that referenced this pull request Jul 21, 2025
@github-actions
Fix dpnp.ndarray constructor call with buffer passed as data proper…
b9cec10 
…ty (#2533)

The PR closes gh-2532.

In the faulty example the buffer was passed with `.data` of
dpnp.ndarray. In that case there is no need to cast dpctl's `usm_data`
to DPNP memory object. 307fc66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.

[dpnp.ndarray] data.ptr usage error
3 participants
@antonwolfy @coveralls @vtavana