Skip to content

Use hasattr instead of getattr in checks for convert_item call #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

Use hasattr instead of getattr in checks for convert_item call #2467

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65aa671
Use hasattr() instead of getattr() in convert_item
antonwolfy Jun 2, 2025
e8462b4
Add a note to changelog
antonwolfy Jun 3, 2025
9612356
Merge branch 'master' into improve-convert-item-in-tests
antonwolfy Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.18.0] - 05/DD/2025
## [0.18.0] - 06/DD/2025

This release achieves 100% compliance with Python Array API specification (revision [2024.12](https://data-apis.org/array-api/2024.12/)).
The release provides enhanced compatibility with NumPy 2.2.5. Window and mathematical routines are complemented by a set of new functions.
Expand Down Expand Up @@ -52,6 +52,7 @@ Moreover, it adds support to build `dpnp` from the source for AMD GPUs.
* Added handling of empty string passed to a test env variable defining data type scope as a `False` value [#2415](https://github.com/IntelPython/dpnp/pull/2415)
* Resolved build issues on non-Intel targets in `dpnp.i0` and `dpnp.kaiser` [#2439](https://github.com/IntelPython/dpnp/pull/2439)
* Ensure consistency in the `dpnp.linalg.LinAlgError` exception raised on singular input matrices for both non-batched and batched cases in `dpnp.linalg.inv` [#2458] (https://github.com/IntelPython/dpnp/pull/2458)
* Updated test f/w to correct a check of array interface while converting to `numpy.ndarray` for comparison [#2467] (https://github.com/IntelPython/dpnp/pull/2467)


## [0.17.0] - 02/26/2025
Expand Down
4 changes: 2 additions & 2 deletions dpnp/dpnp_utils/dpnp_algo_utils.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ cdef ERROR_PREFIX = "DPNP error:"


def convert_item(item):
if getattr(item, "__sycl_usm_array_interface__", False):
if hasattr(item, "__sycl_usm_array_interface__"):
item_converted = dpnp.asnumpy(item)
elif getattr(item, "__array_interface__", False): # detect if it is a container (TODO any better way?)
elif hasattr(item, "__array_interface__"): # detect if it is a container (TODO any better way?)
mod_name = getattr(item, "__module__", 'none')
if (mod_name != 'numpy'):
item_converted = dpnp.asnumpy(item)
Expand Down
Loading