Skip to content

Extend a number of supported types to all numeric dtypes in umath tests #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 27, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 26, 2025

Previously the umath functions were filtered out to to test only int32, int64, float32, float64 (if supported) in test_umaths test.
But currently all numeric dtypes in supported by dpnp. Thus it is proposed to enable all numeric dtypes there.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Mar 26, 2025
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_63 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

Copy link
Contributor

github-actions bot commented Mar 26, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the add-more-dtypes-in-umath-tests branch 2 times, most recently from bd433ba to 60054e5 Compare March 26, 2025 15:28
@antonwolfy antonwolfy force-pushed the add-more-dtypes-in-umath-tests branch from 60054e5 to cdb8e96 Compare March 26, 2025 17:14
Base automatically changed from update-umath-tests to master March 26, 2025 17:36
@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2025

Coverage Status

coverage: 72.181% (+0.01%) from 72.168%
when pulling 1f611d9 on add-more-dtypes-in-umath-tests
into eb8ebf8 on master.

@antonwolfy antonwolfy marked this pull request as ready for review March 27, 2025 09:05
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 771f9b2 into master Mar 27, 2025
66 checks passed
@antonwolfy antonwolfy deleted the add-more-dtypes-in-umath-tests branch March 27, 2025 11:50
github-actions bot added a commit that referenced this pull request Mar 27, 2025
…ts (#2389)

Previously the umath functions were filtered out to to test only int32,
int64, float32, float64 (if supported) in `test_umaths` test.
But currently all numeric dtypes in supported by dpnp. Thus it is
proposed to enable all numeric dtypes there. 771f9b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants