Add correction keyword argument to dpnp.std and dpnp.var
#2300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2300/index.html |
|
Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_8 ran successfully. |
vtavana
approved these changes
Feb 10, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 10, 2025
The PR proposes to add `correction` keyword argument to statistics functions, assuming `dpnp.std`, `dpnp.var`, `dpnp.nanstd`, `dpnp.nanvar` functions and `dpnp.ndarray.std`, `dpnp.ndarray.var` methods. The keyword is mandated according to python array API. The corresponding muted tests are enabled in python array API compliance scope. Also this PR adds improvements to the docstrings of functions from statistics interface. f97b64c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add
correctionkeyword argument to statistics functions, assumingdpnp.std,dpnp.var,dpnp.nanstd,dpnp.nanvarfunctions anddpnp.ndarray.std,dpnp.ndarray.varmethods.The keyword is mandated according to python array API. The corresponding muted tests are enabled in python array API compliance scope.
Also this PR adds improvements to the docstrings of functions from statistics interface.