Skip to content

Change hash to keyword args using the double splat #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

track8
Copy link
Contributor

@track8 track8 commented Jul 4, 2020

Change hash to keyword args using the double splat.

influxdb-0.8.0/lib/influxdb/query/core.rb:29: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
influxdb-0.8.0/lib/influxdb/query/core.rb:88: warning: The called method `query_params' is defined here

Change hash to keyword args using the double splat.

influxdb-0.8.0/lib/influxdb/query/core.rb:29: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
influxdb-0.8.0/lib/influxdb/query/core.rb:88: warning: The called method `query_params' is defined here
@dentarg
Copy link
Contributor

dentarg commented Aug 27, 2020

@toddboom @dmke would be nice to get this one merged and released too, if you have the time :-) thanks!

@toddboom
Copy link
Contributor

@dentarg Sorry, I haven't had commit rights in quite a while. I think this is all up to @dmke!

@dmke dmke merged commit b708621 into InfluxCommunity:master Aug 27, 2020
@dmke
Copy link
Contributor

dmke commented Aug 27, 2020

Sorry, I'm not very active here anymore.

I'll leave it to @hennevogel and/or @ChrisBr to cut a release :-)

@dentarg
Copy link
Contributor

dentarg commented Aug 27, 2020

Thanks for merging! I'll 👀 for that release 🤞

@dentarg
Copy link
Contributor

dentarg commented Dec 14, 2020

@hennevogel or @ChrisBr any chance for a new release with this change?

(The change is required to able to run on Ruby 3 that is expected to land around X-mas 🎅)

@ChrisBr
Copy link
Collaborator

ChrisBr commented Dec 14, 2020

Thanks for the heads up. I think we can release a new version soon 👍

@dentarg
Copy link
Contributor

dentarg commented Jan 18, 2021

@ChrisBr sorry to bother you, but what about that release? 🙇 😆

@ChrisBr
Copy link
Collaborator

ChrisBr commented Jan 20, 2021

@ChrisBr sorry to bother you, but what about that release? 🙇 😆

@dentarg sorry for the delay, Travis seems to be broken and there are some more Ruby 3 issues I would like to fix before releasing a new version. I currently can't tell when I will have time to fix it but if you want to give it a stab, go for it.

@dentarg
Copy link
Contributor

dentarg commented Feb 3, 2021

@ChrisBr I opened #249, want to take a look?

@ChrisBr
Copy link
Collaborator

ChrisBr commented Feb 3, 2021

Awesome @dentarg! I will have a look tomorrow morning but looks promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants